Fix code scanning alert no. 49: Arbitrary file access during archive extraction ("Zip Slip") #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extraction ("Zip Slip")
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
@bgn42 could you add a test for a pack file that uses |
soumeh01
reviewed
Nov 6, 2024
|
Code Climate has analyzed commit 42765ed and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.8% (0.0% change). View more on Code Climate. |
soumeh01
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Open-CMSIS-Pack/cpackget/security/code-scanning/49
To fix the problem, we need to ensure that the file paths extracted from the zip archive do not contain any directory traversal sequences like
... This can be done by adding a check to ensure that the file paths are safe before using them in file operations...before using them.validatemethod incmd/installer/pack.goto include this check.utils.SecureInflateFilefunction is only called with sanitized paths.Suggested fixes powered by Copilot Autofix. Review carefully before merging.